Repository navigation
Conversation
…nerated reference page has a description (website launch) Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…te artefacts Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6572e82e4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Install the package with pyarrow for the Arrow results: | ||
|
|
||
| ```bash | ||
| pip install "krishiv[pyarrow]" |
There was a problem hiding this comment.
Retain the source-build instructions until a package is published
For new users following this page, the installation instructions now offer only pip install "krishiv[pyarrow]", although both README.md and docs/index.md still explicitly state that nothing has been published to PyPI. The deleted quickstart explained that users must build and install the wheel from the repository first; removing that guidance leaves the getting-started flow without an available installation path. Preserve the source-build instructions and qualify the PyPI command until the package is released.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed: nothing is on PyPI yet, so the build-from-source note (maturin build in python/) goes back on this page, matching README.md and docs/index.md. The edit is made; the commit is waiting on a permission block in my session and will be pushed to this branch as soon as it clears.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
main merged in for the CI disk fix (#776); lane: git pull before your next push |
Launch row "docs section pages" (queue-sonnet.md). #740 already added index.md for the root and every section and a description on every hand-written page. What was left:
docs/get-started/index.mdis now the quickstart (install, SQL and DataFrame example, EXPLAIN) with the next-step links below it.quickstart.mdis removed; its links, the docs-example runner, the README-equality test and the check-compat docs test point at the index. The stale "Nothing is published to PyPI yet" paragraph is gone.docs_ext::front_matterfor the xtask generators; the Python generator has its own.Checked:
docs-sql --check,connect-coverage --check,gen_python_docs.py --check, the docs link checker, xtask/common/exec/cli doc tests, clippy and deny (pre-commit).Not run here:
docs-rust(needs rustdoc-md; the Rust pages were patched by the same rule, so the nightly docs-reference job will confirm) anddocs_examples_run.py(needs a built wheel; the CI wheels job runs it).